chore: change filenames of multiplatform files to have a suffix of the respective platforms #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctive targeted platforms
Contributor
Author
|
Closing in favor of #103 due to issues with env secrets not working when workflow is triggered by forks (e2e tests are failing) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #88
Filenames can get confusing in Kotlin Multiplatform if you have multiple files with the same name in different platforms.
This PR introduces filename changes that adds the platform suffix to files that are available in multiple platforms (typically those files exist because of
expect / actual).Google also adheres to this guideline, example: https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:collection/collection/src/jvmMain/kotlin/androidx/collection/ArraySet.jvm.kt
#skip-changelog